PaulQbFeng / too-tanky

3 stars 0 forks source link

Feature equip item #13

Closed PaulQbFeng closed 1 year ago

PaulQbFeng commented 1 year ago

My proposal for item handling

I believe we can improve this solution by creating a Stat class and creating a magic method add so we could add stat class between them like self.bonus_stats = self.item_stats + self.rune_stats

Still need to test auto attack with a setup with armor pen, letha etc

PaulQbFeng commented 1 year ago

all champions should have in theory

the last 2 can be altered when running auto_attack or spell_Q (yet to be created)

BaseChampion should have a method reinitialize_stats /bonus stats