search

PaulQbFeng / too-tanky

3 stars 0 forks source link

added spells #14

Closed nbzpro closed 1 year ago

nbzpro commented 2 years ago

added spells baseline in BaseChampion, and example of annie Q spell, with a test

PaulQbFeng commented 1 year ago

Test ecrire un com depuis gmail

Le lun. 21 nov. 2022 à 20:06, nbzpro @.***> a écrit :

@.**** commented on this pull request.

In champion.py https://github.com/PaulQbFeng/too-tanky/pull/14#discussion_r1028425012:

  • class Passive:
  • def init(self, type :str = "not leveled", level : int = 0):
  • self.nature = "passive" # passive, basic, ulti
  • self.type = type #physical_damage, magical_damage, true_damage, shield, heal, buff ??
  • self.level = level # sometimes depends on level
  • class Q:
  • def init(self, type :str = "not leveled", level : int = 0):
  • self.nature = "basic" # passive, basic, ulti
  • self.type = type #physical_damage, magical_damage, true_damage, shield, heal, buff ??
  • self.level = level # level 0 to 5, with exeptions ?
  • class W:
  • def init(self, type :str = "not leveled", level : int = 0 ):
  • self.nature = "basic" # passive, basic, ulti
  • self.type = type #physical_damage, magical_damage, true_damage, shield, heal, buff ??
  • self.level = level # level 0 to 5, with exeptions ?
  • class E:
  • def init(self, type :str = "not leveled", level : int = 0 ):
  • self.nature = "basic" # passive, basic, ulti
  • self.type = type #physical_damage, magical_damage, true_damage, shield, heal, buff ??
  • self.level = level # level 0 to 5, with exeptions ?
  • class R:
  • def init(self, type :str = "not leveled", level : int = 0 ):
  • self.nature = "ulti" # passive, basic, ulti
  • self.type = type #physical_damage, magical_damage, true_damage, shield, heal, buff ??
  • self.level = level # level 0 to 3, with exeptions ?

la class Spell fait partie de BaseChampion ?

— Reply to this email directly, view it on GitHub https://github.com/PaulQbFeng/too-tanky/pull/14#discussion_r1028425012, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHU4QJ267O4CHA37QEHNUMLWJPBZTANCNFSM6AAAAAASFP2FSQ . You are receiving this because your review was requested.Message ID: @.***>

PaulQbFeng commented 1 year ago

il y a de l'idee, je vais prendre ta structure et faire un peu de refactoring pour eviter les classes dans les classes