PaulQbFeng / too-tanky

3 stars 0 forks source link

Create a Champion, Item and Spell Factory #16

Closed PaulQbFeng closed 1 year ago

PaulQbFeng commented 1 year ago

The idea would be to create a [Entity]Factory class where we would access and instantiate entity with ChampionFactory.get("Ahri"). Currently we use a dictionary.

Would it be a good idea to create a single Factory with get_champ, get_item method ?

Lysxia commented 1 year ago

I think that because the set of items and champs is static, there isn't much point in hiding the dictionaries in a factory. But perhaps there are other benefits.

PaulQbFeng commented 1 year ago

No other benefits than doing something fancy :D

PaulQbFeng commented 1 year ago

Each champion has its one file now