search

PaulQbFeng / too-tanky

3 stars 0 forks source link

Handling of Sheen passive (spellblade) #27

Closed LinSun00 closed 1 year ago

LinSun00 commented 1 year ago

Although the way we coded spells is functional for the moment, at some point we are gonna need to think about harder cases. For example, one case to think about is how spells that apply on-hit effects should interact with spellblade (item passive). https://leagueoflegends.fandom.com/wiki/Champion_ability "After using an ability, your next basic attack within 10 seconds deals 100% base AD bonus physical damage." There are quite a few ways we could go about it, in this issue you can propose any solution you have in mind and we can discuss about each solution's benefits and drawbacks.

nbzpro commented 1 year ago

spellblade is a buff, and buffs have durations and charges (see nami E, jax W...). Spellblade can be treated as such. Or we can calculate the nb of procs according to cooldowns and attack speed, and apply damage optimally

PaulQbFeng commented 1 year ago

Can we rename this issue, Handling of sheen based item ?

PaulQbFeng commented 1 year ago

first implem done with https://github.com/PaulQbFeng/too-tanky/pull/54