PaulQbFeng / too-tanky

3 stars 0 forks source link

Add Mythic item passive bonus #33

Closed PaulQbFeng closed 1 year ago

PaulQbFeng commented 1 year ago
LinSun00 commented 1 year ago
LinSun00 commented 1 year ago

What do you think about making inventory a class ? It can keep track of the number of items of each item_type. This way, we can easily apply the mythic passive according to the number of legendary items in the inventory. We can also define add and remove methods which will be called respectively during equip and unequip in BaseChampion. Other features could include a get_stat method. This would also help making the BaseChampion class a bit cleaner, since it is starting to have a lot of random stuff which makes it a bit confusing imo.

LinSun00 commented 1 year ago

Another feature missing in the Inventory branch:

LinSun00 commented 1 year ago

56