Item Active and Base Spell similarity

[PaulQbFeng]

Item Actives behave like BaseSpells. They have everything in common except spell_nature and spell level.

I am torn between several solutions:

• Rewrite damage mechanism inside BaseItem. Easy to do but there is redundancy with BaseSpell
• Rewrite damage mechanism inside a ActiveItem(BaseItem) subclass of BaseItem (same problem)
• Create a BaseActiveDamage class with the damage mechanism from which we can create a BaseSpell(BaseActiveDamage) subclass and maybe a BaseItem(BaseActiveDamage) or ActiveItem(BaseItem, BaseActiveDamage)
• Have BaseItem.active = BaseSpell (+ code adaptation as it was not written for that)
• Define an active like GaleForceActive(BaseSpell) and assign it to the GaleForce BaseItem

What do you think ?

(current solution is to hardcode the spell damage which can make sense for complex actives such as Galeforce --> see galeforce implem)

[PaulQbFeng]

Example of item active: everfrost

[Lysxia]

I think 3 and 5 are good solutions. Especially ActiveItem(BaseItem, BaseActiveDamage) would be cool.

[PaulQbFeng]

Alrighttttttttttttttttttttttttt

[PaulQbFeng]

closed in https://github.com/PaulQbFeng/too-tanky/pull/61