Spell blade on hit - Githubissues

PaulQbFeng / too-tanky

3 stars 0 forks source link

Closed PaulQbFeng closed 1 year ago

PaulQbFeng commented 1 year ago

Introducespellblade (sheen effect)
Introduce on_hits attribute that stores the on-hit effect to trigger
Basespells now have new attributes apply_on_hit and can_trigger_on_hit
Dirty implem of BaseItem active (quick adaptation of BaseSpell damage mechanism into BaseItem). See https://github.com/PaulQbFeng/too-tanky/issues/53 for refactoring ideas
Caitlyn W and E no uses the on_attack_change_state method to update w_hit or e_hit
Move ratio_damage to damage.py

PaulQbFeng commented 1 year ago

TODO: implement Ezreal Q to check trigger on hit on spell

LinSun00 commented 1 year ago

Can you specify in which cases spells are gonna need a on hit effect method that returns damage ?

PaulQbFeng commented 1 year ago

Can you specify in which cases spells are gonna need a on hit effect method that returns damage ?

No idea, I can remove it for the moment

PaulQbFeng commented 1 year ago

With Ezreal q test written I think the first implem of spell blade is complete