Damage modifiers interaction with on hits

[LinSun00]

It seems like interactions between damage modifiers and on hits are not as straightforward as our code is currently making it out to be. Below, share any interesting results you can find about it so we have a good overview of the way it works.

[LinSun00]

• ASHE: her passive (110% increase) doesn't work on the on_hit_damage, but it works on her q damage. Another interesting thing is that her Q is 5 small attacks, and each of these small attacks is considered as a separate damage instance. This means that if I use Q and attack a champion that I never attacked before, the first small attack will apply a mark (and therefore without applying the passive damage), and the 4 other small attacks will apply the passive damage. This was tested in practice tool on a small wolf (has 0 resistance and you can check the wolve's hp easier than on the dummy), with ashe lvl 2, 5 BF sword and a sheen (because based on simple equations, she needs approx 200 AD atleast for the difference between the 2 ways of calculating the damage to be greater than 1 and lead to a difference in the observation of the wolve's hp)

[LinSun00]

What do you guys think about updating the damage functions in damage.py so that they have an argument on_hit_damage, basic_attack_damage_modifier_percent, damage_modifier_percent, damage_modifier_flat ? This way, everything is just handled in the damage functions, and we just have to add each spell or item effect to the right variable ? @PaulQbFeng

[PaulQbFeng]

I still believe on-hit damages are not part of the modifier of the damage instance that triggers it (be it auto attack or spell). https://leagueoflegends.fandom.com/wiki/Damage_modifier

Damage modifiers refer to damage instances that are modified by a percentage or flat value, causing the damage dealt to be increased or decreased

on-hit is another source of damage that is applied when the inital attack hits.

[PaulQbFeng]

I don't see why it is a problem to leave the on hit effect outside of the attack damage calculation.

To handle local and global for ashe prowler claq + Q for example we would have:

• for the auto damage argument: damage_modifer_coeff = Q_modifier_coeff * Prowler_modifier_coeff
• for the on-hit damage argument: damage_modifier_coeff = Prowler_modifier_coeff

[LinSun00]

There's nothing wrong with it I guess. If you believe it's the way to go, I trust you, go for it

[PaulQbFeng]

There's nothing wrong with it I guess. If you believe it's the way to go, I trust you, go for it

7hours ago overtime dev