Other on hit items

[LinSun00]

• Melee and ranged champions.
• Recurve bow and Tiamat
• init_champion_type method for tiamat
• Tiamat is incomplete (the on hit is weird because it is splash damage which would only matter if we put several targets)

Update (Rageknife):

• Crit_chance getter and setter. Setter acts as a converter: it adds crit_chance to crit_chance_converted and sets crit_chance to 0. This way, when rageknife (or guinsoo's) is equipped, crit_chance is always 0 and crit_chance_converted is used to compute the on hit damage.
• Crit_chance_converted has a public getter and a private setter (bcs this should never be changed outside of the class).
• Tests with yasuo to verify proper interaction with his passive.
• Tests with yone to verify proper interaction with his passive.
• For yone/yasuo/rageknife interaction, apply_crit_damage_modifiers updated in BaseChampion

Side comment:

• Small serrated dirk bug fix: when using the same object to initialize several champions in tests, the serrated dirk would apply its passive each time and have more than 10 lethality.
• Now accounts for differences between base AS and AS ratio

Conclusion: yone and yasuo tests show that this could work even in complicated cases. Tell me what could be improved

[PaulQbFeng]

Y'a des gros conflits qui arrivent, I pray for you

[LinSun00]

Be my guest

[PaulQbFeng]

je galere depuis 30 min a integrer les changemetns de develop sur ma branche damage instance mdr

[LinSun00]

mais du coup c'est bien que j'vois tout ça avant de m'embarquer plus en profondeur sur rageknife