PaulRBerg / cea-template

The official base template for Create Eth App.
https://npmjs.com/package/create-eth-app
1 stars 1 forks source link

Replace the static ABIs package with a truffle project #2

Closed PaulRBerg closed 4 years ago

PaulRBerg commented 4 years ago

The contracts package should be turned into a bespoke truffle project, with a truffle-config.js file and so on and so forth.

kadenzipfel commented 4 years ago

So far, I've added a bare bones truffle project.

I'm thinking it would be good to add:

What do you think? Anything missing?

PaulRBerg commented 4 years ago

Just seen your latest commit. Some feedback:

  1. You accidentally committed the node_modules from within a package. I created an issue for this: #3
  2. I would call the package "contracts" instead of "truffle , to avoid confusion. I know that it would mean that there would yet another "contracts" folder within the "contracts" package folder, but it's the lesser of two evils imho.

Now, about your points:

Some networks in truffle-config Yes, you can see how we added all testnets in the Sablier repo.

A simple smart contract, e.g. a counter I would use Erc20, because this is what I used for CEA so far.

A contract migration Yeah, this would be good.

A test file with some simple test(s), e.g. 'it deploys properly' Yeah, I have a basic token transfer test in my contractz repo.

Aa react file that interacts with the counter We already have this:

https://github.com/PaulRBerg/create-eth-app-source/blob/develop/packages/react-app/src/App.js#L20


Finally, the only things left to do with this repo are:

  1. Make sure that each package works well and that the global scripts defined at the root function properly
  2. Find a nicer nice way of incorporating the "Read On-Chain Balance" button in the UI - at the moment it's really crappy
  3. Publish it somewhere it can be downloaded and unzipped. I'm not sure whether GitHub provides by default. 4 (Optionally) Replace the current svg logo with this much cooler 3d-animated Ethereum logo?
kadenzipfel commented 4 years ago

I've created issues for the suggestions listed so that we can close this one.