Closed juanpcapurro closed 1 year ago
This is awesome work - thanks for creating the fork! I agree that it's a shame that Solhint has remained unmaintained over time.
The no-unused-imports
rule is fantastic. Does your fork enable it by default?
The no-unused-imports rule is fantastic. Does your fork enable it by default?
it's not a default but it's recommended, so the template's config as it stands now would throw warnings on unused imports since .solhint.json
extends the recommended rules.
In the next major release I plan on merging the no-unused-import
and no-unused-var
rules, because conceptually it's kind of the same.
Sounds good! Glad to hear that it's part of the recommended set. I agree that that's where it should be.
also agree with merging twose two rules. Idea for naming: no-unused-members
, or no-unused-entities
.
btw, I have given you a little bit of promotion on Twitter: https://twitter.com/paulrberg/status/1666753482609553408?s=46&t=ENkNXVHfiFNrK4yJomEHgg
One minor request before merging this: can you update the README to mention your fork instead of the original Solhint?
One minor request before merging this: can you update the README to mention your fork instead of the original Solhint?
done. Thanks for pointing it out.
We're trying to keep solhint afloat with a fork, and done some work on it so far, mainly the no-unused-imports rule.
Feel free to raise any issues for rules/improvements you consider prioritary on the solhint-community repo
there's a small announcement post as well.
Any feedback is appreciated, hope this helps ✨