search

PaulRBerg / foundry-template

Foundry-based template for developing Solidity smart contracts
MIT License
561 stars 110 forks source link

chore: first template adjustments #29

Closed 0x-r4bbit closed 1 year ago

0x-r4bbit commented 1 year ago

This is an initial take on adjusting the foundry-template to the Vac's smart contract unit's needs. In a nutshell what this does is:

  1. Update README to not refer to upstream repo where not necessary
  2. Removes PRBergTest library from dependencies
  3. Removes FUNDING.qml
  4. Adjust CI actions

There are more things to be done and decided on in follow-up commits.

0x-r4bbit commented 1 year ago

This PR was accidentally sent to the upstream repository. Sorry for the ping :D

And thank you for this great template! It serves as a great starting point!

PaulRBerg commented 1 year ago

No worries, @0x-r4bbit - I'm glad you like the template.

Quick q: why do you want to remove PRBTest?

Brutal, honest answers are acceptable.

0x-r4bbit commented 1 year ago

Brutal, honest answers are acceptable.

Ah, this is simply because we aim to start out super simple with minimal 3rd-party dependencies. If we feel we need the APIs PRBTest provides, we're very open to re-adding it.

Other than that, no technical reasons or pain points. :)