Declare "method" outside of the loop in "uninstallPlugin"

[PaulRBerg]

This is @IaroslavMazur's suggestion:

it should be more efficient to declare method outside the for loop. Possibly, even with --via-ir.

The reference is for the method variable declaration here:

https://github.com/PaulRBerg/prb-proxy/blob/27594d50f049330c5acfa6cf45448152a2932ecf/src/PRBProxyRegistry.sol#L264

[PaulRBerg]

I made a gas comparison now. What I did:

• Deploy the basic plugin (which has two methods) to Goerli
• Install the basic plugin on a proxy using the current version of the registry (the one with method defined within the loop)
• Define an adjusted version of PRBProxyRegistry with the method defined outside the loop (as suggested by @IaroslavMazur)
  • Note: I enabled the optimized profile when deploying
• Deploy the adjusted registry to Goerli
• Install the basic plugin on a proxy using the adjusted version of the registry

Breakdown:

Tx	Gas Cost
Inside the Loop	122,310
Outside the Loop	122,358

Thus, contrary to our expectations, declaring method outside the loop increases the cost. And the reason for this is via IR - speaking of which, I've tweeted about how surprising via IR can be here.

[IaroslavMazur]

Thus, contrary to our expectations, declaring method outside the loop increases the cost. And the reason for this is via IRhere.

How very weird, indeed! 🤔

Thank you for diving into this!