PaulRBerg / prb-proxy

Proxy contract to compose Ethereum transactions
https://prbproxy.com
MIT License
273 stars 47 forks source link

Move test utils in the src dir #176

Closed andreivladbrg closed 10 months ago

andreivladbrg commented 11 months ago

Same rationale as here

Changelog:

refactor: move test utils in src dir build: install prb test as npm package build: remove prb test git module build: use correct path in update-precompiles script ci: install node js dependencies in build test coverage job chore: update remappings accordingly

andreivladbrg commented 11 months ago

I see that the coverage has significantly decreased. This is because there are more contracts in src which don't have to be tested.

Is there a way to remove a path (~src/test/) from the coverage report?

andreivladbrg commented 11 months ago

Addressed everything in my latest commits.

I see that the slither job has failed and I am not sure why, is it because we need to add pnpm install step?

PaulRBerg commented 11 months ago

Thanks!

I see that the slither job has failed

Dunno, need to investigate but cannot at the moment

andreivladbrg commented 10 months ago

Closing in favor of https://github.com/PaulRBerg/prb-proxy/pull/179