search

PaulSchweizer / flowpipe

Very simple flow-based programming framework.
MIT License
233 stars 30 forks source link

addition of type hints #43

Open Anton-4 opened 5 years ago

Anton-4 commented 5 years ago

I personally love type hints. They allow for better autocompletion and earlier error detection using mypy or PyCharm's integrated checker.

Proper type hints require python 3.6 but they can be stripped for reverse compatibility.

@PaulSchweizer how would you feel about the addition of type hints to flowpipe? I would gladly do the work.

PaulSchweizer commented 5 years ago

Thanks for the idea @Anton-4 , I personally have never worked with type hints, but I do like the concept. We should get a "schema" for the nodes out of the box, at least to a certain extent, right? Like we could investigate the hints at runtime and provide infos on which input plug accepts which type? That would be helpful for the visualizer as well. Only concern is the backwards compatibility, but if we can set up the stripping to be done automatically and publish a stripped version on pypi for py < 3.6, we should be good.

Anton-4 commented 5 years ago

I completely agree :) .