PaulSonOfLars / gotgbot

Autogenerated Go wrapper for the telegram API. Inspired by the python-telegram-bot library.
MIT License
509 stars 114 forks source link

Draft: Add reaction constants #182

Open megum1n opened 3 months ago

megum1n commented 3 months ago

What

Just like in #179, it would be great to have constants for all available reactions. I've added new dependency to get reaction name from the emoji string.

Alternatives

Impact

annihilatorrrr commented 3 months ago

Maybe: https://github.com/PaulSonOfLars/gotgbot#features

No third party library bloat; only uses standard library.

megum1n commented 3 months ago

@annihilatorrrr

No third party library bloat; only uses standard library.

gotgbot package itself still won't use any bloat. Only script to generate code will use external package.

PaulSonOfLars commented 3 months ago

Hey, thank you for your patience on my reply.

I know what you mean by thi not adding dependencies in practice, but it is in the root go.mod file, so there is a questionmark there. Would be best if they weren't there...

One option would be to make the generation files their own module; could we try creating some new go.mod and go.sum files for the codegen only? That should allow us to separate things as needed, and keep the lib dependency-free :)

liuerfire commented 2 months ago

How about make another repo for plugins or handlers need extra deps like python-telegram-bot has ptbcontrib?

PaulSonOfLars commented 2 months ago

@liuerfire That is indeed something I've considered.

Happy to open one up if theres demand :) What kind of things would people be looking for?

liuerfire commented 2 months ago

the most I want is persistent states for conversation :-)