search

PaulStoffregen / Audio

Teensy Audio Library
http://www.pjrc.com/teensy/td_libs_Audio.html
1.07k stars 398 forks source link

Waveshaper "more information" link in webui is broken #456

Open ianloic opened 1 year ago

ianloic commented 1 year ago

Description

In the web ui the "more information" link on the AudioEffectWaveshaper points to https://github.com/dxinteractive/TeensyAudioWaveshaper which 404s

Steps To Reproduce Problem

Go to: https://www.pjrc.com/teensy/gui/?info=AudioEffectWaveshaper Click "more information" on the right

Maybe @dxinteractive took it private or something? There seems to be a fork of some version of it over at https://github.com/joshnishikawa/TeensyAudioWaveshaper but maybe the information therein could be incorporated into the documentation within the audio library itself?

dxinteractive commented 1 year ago

Hey, sorry about this! I deleted the repo some time ago - I didn’t remember that it was linked to from the teensy docs. That fork would be the same as my version as I don’t think I ever updated that code.

Fwiw the waveshaper wasn’t very good as it has no oversampling so you’re very likely to hit problems with aliasing. I’m not sure if anyone else added that in the last 6 years? I would encourage anyone to write a better version. I’m in favour of withdrawing it from the teensy effects library if not.