PaulStoffregen / Encoder

Quadrature Encoder Library for Arduino
http://www.pjrc.com/teensy/td_libs_Encoder.html
561 stars 242 forks source link

Not an issue - but... #54

Closed phaleas closed 3 years ago

phaleas commented 4 years ago

I'm using your excellent library with an ESP32 - after doing so with Arduinos before. It seems, that you changed some files (ESP pins/interrupts) within the current version 1.4.1. These changes effect the users of ESP platform heavily, and many of them would not expect changes within a version they've already have. Please build a 1.4.2, so that ESP users get the latest changes - which are important.

I can confirm that the encoder runs like charm on an ESP32 with the latest changes.

Patrick-Thomas commented 3 years ago

Yes I second this, please release a 1.4.2 version with the latest changes so we can import a ESP32 compatible version easily into Arduino and platformio

PaulStoffregen commented 3 years ago

Done https://github.com/PaulStoffregen/Encoder/releases/tag/1.4.2