search

PaulStoffregen / ILI9341_t3

Optimized ILI9341 TFT Library
http://pjrc.com/store/display_ili9341.html
243 stars 95 forks source link

private #7

Closed FrankBoesing closed 9 years ago

FrankBoesing commented 9 years ago

Hi Paul, all low-level functions are private, which makes it impossible to use them for own fast functions without changing the library. For example, for my spectrum-bargraph display it would be good to have an own specialized fillrect function - this is not possible without changing the library code, now.

What do you think ? Would it be possible to remove the "private" ?

PaulStoffregen commented 9 years ago

Would changing from private to protected be enough? Or do they need to become public?

FrankBoesing commented 9 years ago

Hi Paul, i think protected is ok :-)

Thank you !

Am 30.04.2015 um 23:25 schrieb Paul Stoffregen:

Would changing from private to protected be enough? Or do they need to become public?

— Reply to this email directly or view it on GitHub https://github.com/PaulStoffregen/ILI9341_t3/issues/7#issuecomment-97972992.

PaulStoffregen commented 9 years ago

done https://github.com/PaulStoffregen/ILI9341_t3/commit/136b80bea04641277b9df389010b312aedb1734a