PaulStoffregen / LittleFS

73 stars 20 forks source link

NAND Clock change, Added New Flash Chip, Updated NAND chipinfo Struct and Added ability to get File storage PN #48

Closed mjs513 closed 2 years ago

mjs513 commented 2 years ago

@PaulStoffregen - @KurtE - @Defragster

This PR actual incorporates several changes to the library.

  1. Changed the NAND SPI Clock to 30Mhz (helps to smooth out transfer I think and helps if you are hardwiring the chips), it doesn't seem to help with coping a lot of small files to the N02.
  2. Added a W24Q256W25Q256JW*M flash
  3. I made the chipinfo structure for the NAND match that for the FLASH by adding erasecmd
  4. Added the ability to get a flash part number by adding a getPN command. We keep forgetting the chips we have soldered. Basically allows you get this type of info:
Dump Storage list(8)
store:0 storage:10001 name:sdio fs:2000bf40 pn:
store:1 storage:20001 name:RAM0 fs:2000bd48 pn:EXTMEM
store:2 storage:30001 name:RAM1 fs:2000be14 pn:EXTMEM
store:3 storage:40001 name:PROGM fs:2000bba4 pn:PROGRAM
store:4 storage:50001 name:QSPI fs:2000bc70 pn:W25Q128JV*M (DTR)
store:5 storage:60001 name:Adesto fs:2000c410 pn:AT25SF041
store:6 storage:70001 name:Q64 fs:2000c4ec pn:W25Q64JV*Q/W25Q64FV
store:7 storage:80001 name:Q256JWIM fs:2000c5c8 pn:W25Q256JW*M

More discussion on the thread starting with this post: https://forum.pjrc.com/threads/68139-Teensyduino-File-System-Integration-including-MTP-and-MSC?p=297609&viewfull=1#post297609

mjs513 commented 2 years ago

Thank you

PaulStoffregen commented 2 years ago

Maybe we should use a longer, more descriptive name than "getPN" ?

mjs513 commented 2 years ago

Any preference. Thought about PartNumber DeviceDesc DeviceID

KurtE commented 2 years ago

I agree that longer name would be good, as for what it should be: ???

I am not very good at that: Mike's plus some random ones

getHardwareDescString

getStorageDescString

(or minus String). like getStorageDesc or getStorageDescription

I also wonder if makes sense to add a generic name and make it virtual in FS class

Also wonder if there should be another method, that gives user hint on where the FS is hosted on: like: unknown, SDIO, SPI, SPI1.... MSC(USB) ...

I know there have been requests for something... but that is probably a different subject

Defragster commented 2 years ago

I’ve been using ‘Media’ …

Media’something’ getMediaInfo

KurtE commented 2 years ago

Any consensus on this? Media seams fine to me as well.

From: Defragster @.> Sent: Friday, January 14, 2022 9:03 AM To: PaulStoffregen/LittleFS @.> Cc: KurtE @.>; Mention @.> Subject: [ADV] Re: [PaulStoffregen/LittleFS] NAND Clock change, Added New Flash Chip, Updated NAND chipinfo Struct and Added ability to get File storage PN (PR #48)

I’ve been using ‘Media’ …

Media’something’ getMediaInfo

— Reply to this email directly, view it on GitHub https://github.com/PaulStoffregen/LittleFS/pull/48#issuecomment-1013298627 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAL4MQDL24LREA6NT4WIF7LUWBJKTANCNFSM5L6JRCDQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AAL4MQH6N3ZZDPRQCHQK7WTUWBJKTA5CNFSM5L6JRCD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHRS3LQY.gif Message ID: @. @.> >

PaulStoffregen commented 2 years ago

getMediaName?

KurtE commented 2 years ago

Works for me. Do you want to do it there, or do you want a PR

mjs513 commented 2 years ago

Sorry just got back on line - was playing a bit with getting PNGs to display - thank god for crashreport.

getMediaName - sounds like a commercial - Got Milk but if that what everyone wants to go with I can do the PR!

On Sun, Jan 16, 2022 at 4:50 PM KurtE @.***> wrote:

Works for me. Do you want to do it there, or do you want a PR

— Reply to this email directly, view it on GitHub https://github.com/PaulStoffregen/LittleFS/pull/48#issuecomment-1013959090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABI6DRJ6H7EZQTRBQDLTL6DUWM4R7ANCNFSM5L6JRCDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>