Closed mjs513 closed 2 years ago
Thank you
Maybe we should use a longer, more descriptive name than "getPN" ?
Any preference. Thought about PartNumber DeviceDesc DeviceID
I agree that longer name would be good, as for what it should be: ???
I am not very good at that: Mike's plus some random ones
getHardwareDescString
getStorageDescString
(or minus String). like getStorageDesc or getStorageDescription
I also wonder if makes sense to add a generic name and make it virtual in FS class
Also wonder if there should be another method, that gives user hint on where the FS is hosted on: like: unknown, SDIO, SPI, SPI1.... MSC(USB) ...
I know there have been requests for something... but that is probably a different subject
I’ve been using ‘Media’ …
Media’something’ getMediaInfo
Any consensus on this? Media seams fine to me as well.
From: Defragster @.> Sent: Friday, January 14, 2022 9:03 AM To: PaulStoffregen/LittleFS @.> Cc: KurtE @.>; Mention @.> Subject: [ADV] Re: [PaulStoffregen/LittleFS] NAND Clock change, Added New Flash Chip, Updated NAND chipinfo Struct and Added ability to get File storage PN (PR #48)
I’ve been using ‘Media’ …
Media’something’ getMediaInfo
— Reply to this email directly, view it on GitHub https://github.com/PaulStoffregen/LittleFS/pull/48#issuecomment-1013298627 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAL4MQDL24LREA6NT4WIF7LUWBJKTANCNFSM5L6JRCDQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AAL4MQH6N3ZZDPRQCHQK7WTUWBJKTA5CNFSM5L6JRCD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHRS3LQY.gif Message ID: @. @.> >
getMediaName?
Works for me. Do you want to do it there, or do you want a PR
Sorry just got back on line - was playing a bit with getting PNGs to display - thank god for crashreport.
getMediaName - sounds like a commercial - Got Milk but if that what everyone wants to go with I can do the PR!
On Sun, Jan 16, 2022 at 4:50 PM KurtE @.***> wrote:
Works for me. Do you want to do it there, or do you want a PR
— Reply to this email directly, view it on GitHub https://github.com/PaulStoffregen/LittleFS/pull/48#issuecomment-1013959090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABI6DRJ6H7EZQTRBQDLTL6DUWM4R7ANCNFSM5L6JRCDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
@PaulStoffregen - @KurtE - @Defragster
This PR actual incorporates several changes to the library.
More discussion on the thread starting with this post: https://forum.pjrc.com/threads/68139-Teensyduino-File-System-Integration-including-MTP-and-MSC?p=297609&viewfull=1#post297609