search

PaulStoffregen / OneWire

Library for Dallas/Maxim 1-Wire Chips
http://www.pjrc.com/teensy/td_libs_OneWire.html
579 stars 382 forks source link

BUG in release v2.3.7: [Warning] unused variable `reg` ==> Changes of v2.3.7 are not inside zip-file #130

Open hasenradball opened 9 months ago

hasenradball commented 9 months ago

Hi together,

I see the warnings when using the latest release. Should these not be fixed actually?

grafik

----------------------------- Remove above -----------------------------

Description

Describe your problem.

Steps To Reproduce Problem

Please give detailed instructions needed for anyone to attempt to reproduce the problem.

Hardware & Software

Board: Wemos Mini D1 Shields / modules used: No Arduino IDE version: 2.2.1 Teensyduino version (if using Teensy) Version info & package name : 3.0.2 Operating system & version Any other software or hardware?

hasenradball commented 9 months ago

Hi One addition,

on the ESP32 Pico D4 There are the warnings teated as erros...

grafik

hasenradball commented 9 months ago

Hello all,

why do I get this error?

Can we mark these variables with attribute unused?

grafik

hasenradball commented 9 months ago

@PaulStoffregen, @Jason2866 Hi Paul,

I think with the release 2.3.7 there is something wrong!!! I saw on github the changes for the Attribute unused variable, but when using the version 2.3.7 the changes are not inside the zip-file.

Also on PIO the changes are not inside.

Maybee you have to check the release plese.

Thanks

Frank

hasenradball commented 7 months ago

@PaulStoffregen Can you please publish your changes again on PIO. Thanks.

PaulStoffregen commented 6 months ago

Sorry, I do not know how to check PIO.

PaulStoffregen commented 6 months ago

Can you try using with Arduino IDE and confirm if the problem exists with Arduino library manager?

hasenradball commented 6 months ago

@PaulStoffregen Hi Paul, it seems also on the Arduino library it is the same issue. It seems the changes are not in the release 2.3.7.

hasenradball commented 6 months ago

@PaulStoffregen I now the issue .... You should make a new release maybee v2.3.8 The changes are not in the v2.3.7 See here:

grafik

If you can make a new release also on PIO would be great! 👍

Jason2866 commented 6 months ago

Probably it makes sense to add the needed changes for upcoming espressif32 Arduino Core 3.0.0 before doing a new release. -> #132 We changed for Project Tasmota to be compatible with Arduino Core 2.0.14 and Core 3.0.0 in our fork ot this lib. The changes are here https://github.com/arendst/Tasmota/blob/development/lib/lib_basic/OneWire-Stickbreaker/OneWire.h It needs porting to the actual version from here.

PaulStoffregen commented 6 months ago

I've merged several ESP related pull requests. But I didn't see any for espressif32 Arduino Core 3.0.0. If there is a PR pending, can you tell me which one I missed?