PaulStoffregen / OneWire

Library for Dallas/Maxim 1-Wire Chips
http://www.pjrc.com/teensy/td_libs_OneWire.html
579 stars 382 forks source link

updating codebase of lib #39

Open orgua opened 6 years ago

orgua commented 6 years ago

hi paul, i know you only anticipate PR for new hardware support because you say the lib has "very mature code", but this statement is simply not true. over the years it became a big patchwork of ancient or even useless code. there were several bugs to find. the most obvious one is in the bus-power feature. the function write_bit() always powers the bus without permission. I modernized and extended the interface of the lib without breaking old code. i did tests on several platforms. see list of changes below. where do you see problems in merging this PR?

I would like to co-maintain the onewire-lib with you. Currently I have rebuild and maintained the https://github.com/orgua/OneWireHub project for emulating slave-devices and i would like to apply my experiences to the onewire-master-lib.

changes i made so far:

orgua commented 6 years ago

Hi Paul,

it is hard to guess your thoughts when you say nothing at all.