search

PaulStoffregen / OneWire

Library for Dallas/Maxim 1-Wire Chips
http://www.pjrc.com/teensy/td_libs_OneWire.html
579 stars 382 forks source link

Ds2482 dev branch #62

Closed sraff closed 5 years ago

sraff commented 5 years ago

add method to address 1-wire device via DS2482

PaulStoffregen commented 5 years ago

why does this pull request change almost everything in the library, just to support 1 more chip?

sraff commented 5 years ago

Hi Paul,

perdon me, I made made the pool request by mistake whilst I was merging it into my master copy of yours code...

By the way, I added a method witch use this I2C to 1-Wire bridge: https://datasheets.maximintegrated.com/en/ds/DS2482-100.pdf

I almost did't touch your routine and the timing shouldn't be affected at all. Depending on the initializzation of the OneWire istance the function use one or the other method. I needed to do that because I have an Arduino project with to two 1-wire buses, one with the DS2482 master and the other using your library. I just wanted to you the same function to drive both busses.

Hope this is usefull for somebodyelse. Let me know if you are are happy to include this method into the library.

kind regards, Stefano

Il giorno gio 27 set 2018 alle ore 00:55 Paul Stoffregen < notifications@github.com> ha scritto:

why does this pull request change almost everything in the library, just to support 1 more chip?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/PaulStoffregen/OneWire/pull/62#issuecomment-424895501, or mute the thread https://github.com/notifications/unsubscribe-auth/Ao1dRuFPc36-7c2di09WGME8Y7a60Fm6ks5ufAXwgaJpZM4W1aGU .