search

PaulStoffregen / Time

Time library for Arduino
http://playground.arduino.cc/code/time
1.24k stars 664 forks source link

Fix *ToTime_t macros to work with the Arduino compiler #145

Open tomer-w opened 4 years ago

tomer-w commented 4 years ago

The daysToTime_t (and all other similar macros) does not compile correctly on recent Arduino SDK. Apparently the compiler require that there will be no space between the macro name and the (x) parameter definition.

46Leo commented 3 years ago

I can confirm the issue with Arduino IDE 1.8.13 on Windows 10. The solution for me was removing space and double parentheses, as you did in your modified header.

jpasqua commented 2 years ago

Same issue with: Arduino IDE: 1.8.13 Boards: Uno, ESP8266, ESP32 Compiler VERSION for ESP8266: 4.8.2

tomer-w commented 1 year ago

ping...

murmlgrmpf commented 10 months ago

@PaulStoffregen Thanks for the brilliant library! Please consider to apply this pr, it is fixing the issue of the broken makros for me as well. I am working with up to date PIO in VSC and my target is a mega2560.

tomer-w commented 10 months ago

@murmlgrmpf , I hate to say it, but this repository is dead. Last checkin was 2021. This is what happen with OSS when there is no continuity and people change focus without nominating people who will replace them as maintainers.

tomer-w commented 10 months ago

Actually, I'm taking it back. Seems @PaulStoffregen was active on github lately. Maybe he is just ignoring this repository specifically.

tomer-w commented 10 months ago

Actually, i'm taking it back. Seems @PaulStoffregen was active on github lately. Maybe there is a chance this will get fixed.