search

PaulStoffregen / Time

Time library for Arduino
http://playground.arduino.cc/code/time
1.24k stars 665 forks source link

Delete Time.h #98

Open borisneubert opened 6 years ago

borisneubert commented 6 years ago

remove Time.h because it conflicts with time.h on file systems with case-insensitive filenames, e.g. Windows

vshymanskyy commented 6 years ago

@PaulStoffregen this is a good idea

PaulStoffregen commented 6 years ago

@michaelmargolis - thoughts on this?

How about published books using Time.h vs TimeLib.h in example code?

jamesmyatt commented 5 years ago

This causes me lots of problems. If this sort of change cannot be made to this library for the benefit of lots of future users, then the only alternative may be forking it.

PaulStoffregen commented 5 years ago

I am currently working on a hardware project. No changes will happen with this library or any others I maintain until June 2019. Sorry, I need to pay the bills now (so I can do more open source stuff in the future). I've been burned many times before when making "trivial" changes to software without proper testing. Not going to do down the road again. Remind me about this next summer.

borisneubert commented 5 years ago

@jamesmyatt For the time being you could use my fork

PaulStoffregen commented 5 years ago

@michaelmargolis - What is the situation with printed books in circulation? Will removing Time.h break examples? How much legacy from the old days are we facing?

jamesmyatt commented 3 years ago

This can finally be closed: https://github.com/PaulStoffregen/Time/commit/b0cfc3c941a795672d44db94c3d2d341887bd42a