PaulStoffregen / Time

Time library for Arduino
http://playground.arduino.cc/code/time
1.24k stars 665 forks source link

Bogus return in TimeRTCSet example #99

Open SukkoPera opened 6 years ago

SukkoPera commented 6 years ago

The return at line 69 of the TimeRTCSet example sketch is probably unwanted, since it completely bypasses the time consistency check that follows.

I had the issue that bogus characters on the serial line screwed up my RTC:

RTC has set the system time

18:37:44 8/5/2018
0:00:18 1/1/1970
0:00:20 1/1/1970
0:00:21 1/1/1970

This was revealed after I added a debug message to the serial read code:

RTC has set the system time

19:57:45 8/5/2018
SETTING TIME TO 19
0:00:19 1/1/1970
0:00:21 1/1/1970

Removing that return should avoid (or at least mitigate) this issue.