search

PaulStoffregen / USBHost_t36

USB Host Library for Teensy 3.6 and 4.0
165 stars 85 forks source link

Updates for MassStorageDrivver.cpp and USBHost_t36.h #55

Closed wwatson4506 closed 3 years ago

wwatson4506 commented 3 years ago

Paul, I have updated the msProcessError() method so that external processing sense codes can be parsed and displayed as descriptive error strings using a sense key, additional sense codes and additional sense code qualifiers. I also modified msReset() and msGetMaxLun() methods to use an interface number with wIndex in mk_setup(). In an email I received hathach mentioned that wIndex should be set to an interface number. So far with the bNumInterfaces at 1 and bInterfaceNumber at 0. I'm not sure if this only applies to just the control pipe. Link is here: https://github.com/PaulStoffregen/USBHost_t36/pull/42#discussion_r583694595.

PaulStoffregen commented 3 years ago

I see there's one Serial.printf() in this patch. Is than intentional?

wwatson4506 commented 3 years ago

There is one Serial.printf() added to MassStoragedriver..cpp in this patch. Line #564. There are several others previously used before the patch. This was in msProcessError().

PaulStoffregen commented 3 years ago

Ok, fine for now. Before a non-beta 1.54 release, these Serial.print should be turned into the libraries print & println, so they only stuff is USBHost_t36.h has been edited to turn on verbose printing.

wwatson4506 commented 3 years ago

Ok. will do it. When I started thinking about it I suspected that was what the question was about.

Thanks