PaulStoffregen / USBHost_t36

USB Host Library for Teensy 3.6 and 4.0
165 stars 85 forks source link

Improve MSC Reset() and GetMaxLun() #57

Closed hathach closed 3 years ago

hathach commented 3 years ago

This add bInterfaceNumber member to use with msReset() and msGetMaxLun() as follow up to #55 . The bInterfaceNumber is part of interface descriptors and can be saved while claim() interface to be used with reset and get maxlun later on. It is not actually the case where interface is passed by application, sorry for not being clear enough on the comment at https://github.com/PaulStoffregen/USBHost_t36/pull/42#discussion_r583694595

This PR is tested with single MSC class as well as composite device that has CDC as first interface (0,1) and msc as 2nd interface (2)

PaulStoffregen commented 3 years ago

@wwatson4506 - Should I merge this?

wwatson4506 commented 3 years ago

Yes Paul. Downloaded and tested with example files for SD, SdFat, UsbMscFat and uSDFS. No problems detected at this time. What HaThach changed makes more sense. Did you get the pull request for the changes from Serial.prinf's to print and println? I get kind of confused with pull requests yet:) And Happy Birthday. I wish I was still your age:)

On Mon, Mar 1, 2021 at 4:19 AM Paul Stoffregen notifications@github.com wrote:

@wwatson4506 https://github.com/wwatson4506 - Should I merge this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PaulStoffregen/USBHost_t36/pull/57#issuecomment-787906354, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH2Q7QBZACPC42EYHPVCWLTBOA3LANCNFSM4YMHXPRQ .