search

PaulStoffregen / teensy_loader_cli

Command line Teensy Loader
http://www.pjrc.com/teensy/loader_cli.html
332 stars 152 forks source link

Patch for Mac OS HID access #19

Closed rixtox closed 8 years ago

rixtox commented 8 years ago

These lines will cause HID access problems when compile with libusb. It's better to comment out these lines as default.

PaulStoffregen commented 8 years ago

Could you please add a comment about which version(s) of OS-X this has been verified to work?

rixtox commented 8 years ago

With OS=LINUX and this patch applied. It's verified working on OS X 10.11.2 (El Capitan) and previous 10.10 (Yosemite) and 10.9 (Mavericks).

PaulStoffregen commented 8 years ago

Oh, I see. I only looked at the changes and didn't see you put this in the Linux section.

I can't merge a change that breaks things for Linux. This needs to be done in a way where Mac users can configure it for Macs.

Is this really even necessary? Is the Mac version of the code not working on El Capitan?

rixtox commented 8 years ago

No, I believe they are not working at all.

PaulStoffregen commented 8 years ago

I hope you can understand why I can't merge a change that breaks Linux.

rixtox commented 8 years ago

I surely understand that. This is just a workaround for Mac OS X if someone want to use it. You can just leave it closed for the record. I will submit a temporary patch on Homebrew, and wait for any progress from upstream. Is that okay?

PaulStoffregen commented 8 years ago

I believe the proper solution is to fix the OS-X native code. Using the Linux code on Mac with this patch is a ugly hack. If anyone wants to use this hack, they certainly can. I'm even willing to add another build type to the makefile. But I can't merge any patch that breaks support for Linux users.

rixtox commented 8 years ago

Yes, you don't need to merge it at all. It's just a quick and dirty workaround. Close this issue and make a TODO will work for you. I just want to have a working Hombrew formula and that's all.

PaulStoffregen commented 8 years ago

merged by #20