Improper return value from parse_hex_line in case of bad checksums - Githubissues

PaulStoffregen / teensy_loader_cli

Command line Teensy Loader

http://www.pjrc.com/teensy/loader_cli.html

331 stars 152 forks source link

Improper return value from parse_hex_line in case of bad checksums #80

Open farmisen opened 2 years ago

farmisen commented 2 years ago

looks like parse_hex_line should return 0 instead of 1 when the checksum is invalid

https://github.com/PaulStoffregen/teensy_loader_cli/blob/master/teensy_loader_cli.c#L927 https://github.com/PaulStoffregen/teensy_loader_cli/blob/master/teensy_loader_cli.c#L936