search

PaulUithol / Backbone-relational

Get and set relations (one-to-one, one-to-many, many-to-one) for Backbone models
http://backbonerelational.org
MIT License
2.34k stars 330 forks source link

Backbone 1.3.2 support #563

Closed philfreo closed 7 years ago

philfreo commented 8 years ago

http://backbonejs.org/#changelog

I can see some of the changes especially like options.changes potentially changing how BBR should work (perhaps simplifies things)

Overall it'd be great if there was a clear indication in the README or on http://backbonerelational.org/ which versions of Backbone BBR have been specifically tested / optimized for already, so that when a new version comes out there's no guessing.

bpatram commented 8 years ago

@philfreo I completely agree. We will need to update the test suite to test against multiple versions of Backbone. As of BBR version 0.10.0 the dependency uses >=1.2.1 for Backbone which will most likely cause issues when newer versions of Backbone are released (like 1.3.2). I have not ran any tests on 1.3.2 yet to verify if it contains anything that might break BBR.

Let's plan in the next release to get Backbone support to be between 1.2.x and 1.3.2.

jeremymlane commented 8 years ago

I ran tests on Backbone 1.3.1 - 1.3.3 and everything looks good (with one minor update). Will submit a pull request.