search

PaulUithol / Backbone-relational

Get and set relations (one-to-one, one-to-many, many-to-one) for Backbone models
http://backbonerelational.org
MIT License
2.34k stars 330 forks source link

Support up to Backbone 1.3.3 #571

Closed jeremymlane closed 7 years ago

jeremymlane commented 8 years ago

I ran the tests for BBR on Backbone 1.3.1 - 1.3.3 and verified everything works. I also updated tests to reflect the new support. There was one minor change that needed to be made. This fixes #563

lddubeau commented 8 years ago

Is there anything I can do to help get this PR incorporated into a new release?

bpatram commented 8 years ago

@lddubeau You shouldn't have issues using Backbone 1.3.2+ (see https://github.com/PaulUithol/Backbone-relational/issues/563#issuecomment-226237681). But I have not tested against that version myself.

What would be nice is to expand the TravisCI tests to test against multiple versions of backbone (and underscore). Marionette does this exact thing (here is their karma config file: https://github.com/marionettejs/backbone.marionette/blob/master/.travis.yml). This is outlined here: #572. I haven't had time to actually push up the next branch, but you are more than welcome to add this from the current master. It shouldn't be difficult to merge in afterwards

Edit: the next branch has been pushed in its current state