search

PaulleDemon / tkVideoPlayer

Video player for tkinter.
MIT License
79 stars 25 forks source link

Feat: Add Loop property #33

Open CodeYan01 opened 1 year ago

CodeYan01 commented 1 year ago

Makes it easier to toggle looping, and prevents flickering that would be caused by calling TkinterVideo.play() after the "<>" event.

Fixes #32

CodeYan01 commented 1 year ago

I only made it a property (with get/setter) for consistency with other functions like keep_aspect and set_resampling_method having setter functions that don't really do anything else. But having a getter too imo is important if you're gonna have a setter, so I made it a Python property for completeness

PaulleDemon commented 1 year ago

Hi, I am currently will look into this as soon as I am free

PaulleDemon commented 1 year ago

Ok, I am looking into this. @Brandon4466 can you help me understand which part is not being Garbage collected? I will try to implement this ASAP

CodeYan01 commented 1 year ago

@Brandon4466 were you suggesting changes to this PR? Because on github it shows that you are suggesting changes but I don't see anything new that you changed.