Pausansol / Camilo

Sketch plugin specially crafted to work in Design systems with multiple themes
MIT License
188 stars 18 forks source link

Broken in Sketch 95.3 #48

Open custa1200 opened 1 year ago

custa1200 commented 1 year ago

Following error shows up in Sketch Dev Tools

MOJavaScriptException: TypeError: null is not an object (evaluating 'library.sketchObject.document().documentData') main-view.js:42:62 forEach [native code] main-view.js:39:20 script.js:16:30 __skpm_run script.js:1368:19 __skpm_run [native code]

justinspencer commented 1 year ago

Same here.

marc-clancy commented 1 year ago

Has anyone found a replacement for this plugin?

AndrewBetlyon commented 1 year ago

Figma :) – Brand & UI/UX Designer Born & Raised www http://www.born-and-raised.com/ | insta https://www.instagram.com/born.and.raised/ | dribbble https://dribbble.com/Born-And-Raised

On Wed, May 17, 2023 at 1:02 AM Marc Clancy @.***> wrote:

Has anyone found a replacement for this plugin?

— Reply to this email directly, view it on GitHub https://github.com/Pausansol/Camilo/issues/48#issuecomment-1550737610, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVFSZ4XWBAFDUYJ57T3MA3XGRLWZANCNFSM6AAAAAAV3BJGGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

custa1200 commented 1 year ago

Figma :) – Brand & UI/UX Designer Born & Raised www http://www.born-and-raised.com/ | insta https://www.instagram.com/born.and.raised/ | dribbble https://dribbble.com/Born-And-Raised

On Wed, May 17, 2023 at 1:02 AM Marc Clancy @.***> wrote:

Has anyone found a replacement for this plugin?

— Reply to this email directly, view it on GitHub https://github.com/Pausansol/Camilo/issues/48#issuecomment-1550737610, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVFSZ4XWBAFDUYJ57T3MA3XGRLWZANCNFSM6AAAAAAV3BJGGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Any other useless comments?

yaburi commented 1 year ago

@custa1200 @justinspencer @marc-clancy I've forked and made some changes to the plugin, it should be working on newer versions of Sketch now. You can download the new version from this branch and let me know if it works. Pull request has been raised here

marc-clancy commented 1 year ago

@yaburi I've just installed the fix on Sketch v96.3 and the update seems to be crashing Sketch

yaburi commented 1 year ago

@marc-clancy Are you on macOS Ventura? I've seen a memory allocation crash happening like this: dyld_process_snapshot_create_for_process failed with 5 I'll try updating to Ventura soon and seeing if I can fix it.

yaburi commented 1 year ago

@custa1200 @justinspencer @marc-clancy Hey guys, I've updated to Ventura and pushed some fixes. It should be working on Sketch 96 and 97 beta now.

marc-clancy commented 1 year ago

@yaburi, thanks for the update! I tried it out and it doesn't seem to be crashing and it's relinking symbols to the external library you select, which is awesome! From memory the original Camilo used to then also delete the local versions of those symbols to avoid confusion but it seems to still be keeping local copies of symbols.

yaburi commented 1 year ago

Hey @marc-clancy, are you talking about symbols that are in external libraries, but have been "Made Local"?

I just tested it out and it seems to remove the local version from the Symbols page after running Camilo using the "Apply to document" option.

image

This is on Sketch 97 Beta. Edit: also works on 96

NaClZhang commented 3 months ago

@yaburi hi, your version is not compatible with Sketch 100.2 on macOS Sonoma.