search

PauseAI / ProjectBot

A python bot that does project tracking from a discord server to a notion database
3 stars 3 forks source link

"wants to help" should not be removed when onboarding starts, but at the end #9

Open joepio opened 4 months ago

joepio commented 4 months ago

The wants-to-help role is removed when the onboarding starts (after the emoji is set), but this should happen after the onboarding has completed.

This is a problem, because the tag helps onboarders identify who should be reached out to as they are posting things on the discord server.

anthonybailey commented 1 month ago

@Will9371 - in conversation you've reported this issue as no longer current.

If I understood correctly: because the code for the bot to request the role be removed still runs, but in a context where it does not have permissions on the server to act.

Please confirm?

Please seek validation from @joepio.

joepio commented 1 month ago

I removed the role edit permissions from the bot, which seems a decent temp fix

anthonybailey commented 1 month ago

Thanks Joep. Is there a record somewhere of what change you made and when?

Can you verify that the bot would not as a result error out before performing other actions in the sequence?

https://github.com/PauseAI/ProjectBot/blob/bd4d13e674a291bf21d4aee827236597c46cade8/onboarding/onboarding_config.py#L349

I note e.g. https://discord.com/channels/1100491867675709580/1227539725431345253/1299403839446843523

On Fri, 25 Oct 2024, 22:29 Joep Meindertsma, @.***> wrote:

I removed the role edit permissions from the bot, which seems a decent temp fix

— Reply to this email directly, view it on GitHub https://github.com/PauseAI/ProjectBot/issues/9#issuecomment-2438906400, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXXDI5TGK7NEHGIFWRM7TZ5KZ2JAVCNFSM6AAAAABLI3GUSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYHEYDMNBQGA . You are receiving this because you commented.Message ID: @.***>