PauseAI / pauseai-website

Website for PauseAI.info
https://pauseai.info
Other
10 stars 37 forks source link

Add full text search using Pagefind #95

Closed Wituareard closed 7 months ago

Wituareard commented 7 months ago

Two things I'm not entirely happy with:

netlify[bot] commented 7 months ago

Deploy Preview for pauseai ready!

Name Link
Latest commit d8d043a5494ab7a3b7755b99c4686ed1d43c0bbb
Latest deploy log https://app.netlify.com/sites/pauseai/deploys/65cc98aada3d7a0008a91a14
Deploy Preview https://deploy-preview-95--pauseai.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

joepio commented 7 months ago

Great job!

Regarding the separate page: is there a technical reason for this? Seems pretty doable to move it into a component to the navbar

Regarding the second vite build run: Is there a way we can change the config to build the search index in the first vite build run?

joepio commented 7 months ago
Screenshot 2024-02-14 at 11 51 37

This looks absolutely amazing, great job!

joepio commented 7 months ago

What's your discord handle btw? I'm assuming we've interacted on the discord before but I don't know who you are!

Wituareard commented 7 months ago

No technical reason, I just tried too long to build a decent looking and functional modal component and eventually gave up.

The problem is that the indexing would need to happen after the HTML files are generated, but before the netlify function is generated. Maybe that'd be possible with a vite or sveltekit plugin and a lot of investigation on how exactly things work, but it's probably not worth the effort.

The UI is mostly provided by Pagefind which is one reason I liked the library.