PavelZinchenko / event-horizon-main

GNU General Public License v3.0
28 stars 6 forks source link

[BUG] The knockback of Antimatter Torpedo still not fixed (build 1752) #459

Open Neuron114 opened 2 months ago

Neuron114 commented 2 months ago

Build 1752, the knockback is still unhinge

here's the video of testing it to normal ship and asteroid, and wormship

https://github.com/user-attachments/assets/47c9bf98-0f6e-4c67-9dfe-daa358822292

https://github.com/user-attachments/assets/122e0006-7560-4f8a-b530-c4aa44b0f53d

PavelZinchenko commented 2 months ago

How many torpedoes does the ship in the video firing? The knockback effect is cumulative, so hitting the target with 10 torpedoes at once will amplify the effect by 10 times.

Neuron114 commented 2 months ago

How many torpedoes does the ship in the video firing? The knockback effect is cumulative, so hitting the target with 10 torpedoes at once will amplify the effect by 10 times.

My Syberia fired 2 Torpedoes. But even with 1 torpedo, it still able to send asteroid that far (if you pay attention to the first video, the first torpedo hit enemy, and then the second torpedo hits the asteroid offscreen, and after awhile, you can see there's asteroid traveling that fast.)

Inedilarion commented 2 months ago

Maybe, knockback was increased by PowerMultiplier of parent ammo?

PavelZinchenko commented 2 months ago

Are you using the original database or a mod? I reduced the knockback strength of the antimatter torpedo from 40 250 (push power power multiplier) to 0.5 * 250. I’ve tested it multiple times, but it isn’t strong enough to send an asteroid flying with a single hit.

Inedilarion commented 2 months ago

0.5 * 250

But this is absolutely huge knockback! Heavy railgun has 0.6, heavy energy wave 0.3...

Inedilarion commented 2 months ago

Tested now by myself https://github.com/user-attachments/assets/9b504fd4-1317-4473-a31b-4a2d295224b6

PavelZinchenko commented 2 months ago

Railgun and Energy Wave have slightly different effects: their knockback is calculated as [bullet velocity] * [effect power]. In contrast, the antimatter torpedo applies knockback in all directions from its center, disregarding its velocity.

It seems I uploaded the wrong build to the releases, which does not include the fix. I’ve just uploaded the correct one; please check it.

Inedilarion commented 2 months ago

please check it.

Checked. Now asteroids feeling fine, but enemies -- no. Video attached:

https://github.com/user-attachments/assets/1e9c0c33-1458-431b-ab86-a20210c4e9a5

Railgun and Energy Wave have slightly different effects: their knockback is calculated as [bullet velocity] * [effect power]. In contrast, the antimatter torpedo applies knockback in all directions from its center, disregarding its velocity.

Maybe, enemies speed is also taken into account in knockback calculations?

Neuron114 commented 1 month ago

Tested the latest version, the knockback is back to normal for every ship (normal as in normal for the new antimatter torpedo rework). It doesn't seems launch ships unhingedly now (tested against wormship xxx).

altho normal for the new antimatter torpedo, the knockback is still arguably high, but that is the discussion for other topic