Brainstorming - Githubissues

tjeh commented 10 years ago

I do not know if this is the right place and whether this should be separate "feature requests" thus here is a list of points that might be worth consideration.

EPG Chart

will display a complete day, thus programm only running for 5-10 minutes are barley visible in both horizontal and vertical display

General

restart button within the application (avoids the stop - start oddyssee within the synology package manager)
fix permission of installed package. Currently files are either belonging to admin:users or root:root. Maybe it should be considered to create a specific user ie. tvstreamrecord:root?
button to perform code update from git directly
if port is configured incorrectly (ie. another program already on the port running) and tvstreamrecord has been stopped there is currently no way to reset/edit the port

Config

use dropdown for zoomlevel to avoid absurd values (ie. >= 3 makes no sense). Or implement "word" values like (vertical small, vertical middle, vertical huge...)
group config options that will need a restart
make available a selection dialog for the "Path for your recordings"

Channels

possiblilty to set default values for "show xxx entries"
gui not consistent grab epg uses "+ and -" while the dialog uses a slider

EPG List

possiblilty to set default values for "show xxx entries"

So for future discussion points shall I open sepeare Issues and/or submit the above as seperate issues/ideas?

Pavion commented 10 years ago

Some of this I've already considered. I write my considerations and you are to decide, which issues you keep and which are explained, ok? :)

Pavion commented 10 years ago

First of all: please don't think, that I'm just trying to get rid of you. I thank you for your feedback and I will consider some things for future releases. Any further feedback is anytime welcome. On the other hand I might be a bit lazy and I've got absolutely no sense for design, but I vow that I've given most of these issues a consideration in my time and rethought it now. But as the saying goes: Never touch a running system. :)

EPG Chart

That's why I've implemented different zoom levels. I've also considered using smaller time intervals (4h / 8h) but dropped the idea. What would you recommend?

General

Nice idea as such. I would need a separate launcher to do this. The question is, why should it be used at all? You would need it to change the port once, most non-advanced users don't even do it. Why make things complicated?
Why should I add a separate user? This will cause permission problems each time a user changes his recording folder.
No way! Git can also contain broken/untested/unfinished code, which may have negative impact, destroy database and so on. With each stable version I distribute my program through community hub, so every user can safely update his version through Package Center. With DSM5.0 this should even happen automatical.
Well, yes and no. Yes, it's possible to enter an incorrect port and crash the program. This state can only be reset by reinstalling the software. To avoid this, I will implement a plausibility check. As for issues with other software, a user can still stop this other software, start my program and change the port. There are many ports still free. Honestly, if my program can't start, I fail to see how it can be reset. As DS doesn't offer recovery buttons, each non-advanced user still have to reinstall my program. Each advanced user can hack his way back by editing tvstreamrecord.py and setting a new port.

Config

I admit, config was my first and less-edited page. Some visual improvements would be nice. Zoom level was a latest addition and I've got null feedback on values used, so I can't judge the best options for a combobox. I think, most users don't change it at all or change it but once.
There are only two options, which require restart, which is clearly stated.
Honestly I don't know how to implement a path selection dialog. I'm also fearing security issues with some browsers (PC1 runs a JavaScript, which is to access filesystem of PC2, hm).

Channels

I'll look for a callback function and try to store this values in the database
To distinguish them from each other. Other way would be to make a separate column pro item, which would just waste space and lead to confusion if column headers are not visible. What is your solution?

EPG List

see above

Please review my answers and reconsider, which issues you would keep, then answer again or make separate issues as you wish.

With best regards Pavion

Pavion commented 10 years ago

Plausibility check for server port and bind address with some user feedback added: https://github.com/Pavion/tvstreamrecord/commit/acd70004f6726afe38279fa1cf6a81d117662225

Pavion commented 10 years ago

Table length will now be saved automaticly: https://github.com/Pavion/tvstreamrecord/commit/374b8b408940461c9625e0f84b4ac3826e9129b3

tjeh commented 10 years ago

EPG Chart

I see your point, after playing around with the configuration value I ended up with my favorite: -2

General

The port change issue only came up when I fist played around with tvstreamrecord. Once one has descided for a port it will most likely stay the same
Access issues shouldn't be the case as the group usually grants the access right to the recording folder. I just noticed that after installation of tvstreamrecord on will find a mixture of file ownerships (aka root:root and admin:users) ... nevertheless just cosmetics
didn't know that about DSM 5.0 so the update problem will be solved by synology itself :)
As far as I can see with your implementation of https://github.com/Pavion/tvstreamrecord/commit/acd70004f6726afe38279fa1cf6a81d117662225 you limit the available port to 32000? Won't work for me as I like mine above 60000 :)

Config

well that is true the combobox would need some user feedback
forget my suggestion about the path selection dialog as this would render the "leave out the concluding slash to add it to the file name of the recording"

Channels

I will test https://github.com/Pavion/tvstreamrecord/commit/374b8b408940461c9625e0f84b4ac3826e9129b3 --> works perfectly
just an idea.. dont use a "plus sign" maybe just use a "EPG" graphic that is sort of blurred when unselected and fully visible if selected (sort of hoover effect)

Thanks for your extensive reply Regards tjeh

Pavion commented 10 years ago

EPG#1: That I call freedom of selection!
General#2: Cosmetics I'd rather avoid. It would be a nightmare of any system administrator, if each little piece of software is to come with its own user.
General#3: Where do you see an update problem now? As of current DSM, each new version will already be shown in Package Center and can be easily upgraded by user.
General#4: Oh, sorry... With my new version, which is already available through DSM, port range is already limited. Should I increase the port range again?
Channels#2: If I'm to tamper with css again, I'll take a look at EPG button.

tjeh commented 10 years ago

General 2# /3#: no you got me, wrong I agree with you
General 4#: I would like that. Limiting only the lower bound is probably a good idea
Channels#2: brilliant

Pavion commented 10 years ago

May I close this issue then? You are free to make new ones and contact me as you wish. By the way, there soon may be a mobile version of my program: there is an other GitHub user, who've forked my project today to implement this. Stay tuned!

Pavion commented 10 years ago

Structured configuration added: https://github.com/Pavion/tvstreamrecord/commit/f880894debad4dd6318404c22ababb0c20ed20b0

Pavion / tvstreamrecord

Brainstorming #5