Multiple GUI improvements

PavlidisLab / GemBrow

The Gemma Browser

Apache License 2.0

3 stars 1 forks source link

Open ppavlidis opened 4 months ago

ppavlidis commented 4 months ago

I'm just going to list these and separate issues can be made if need be, and I'll just update this issue with more suggestions for now.

[x] In the 'expanded' row view, the short name should be listed again and made a link. The row above is visually 'detached' from the expanded region - it's hard to tell if it goes with the expanded view above, or below it, and the "up arrow" adds to the cognitive load to navigate, as does the fact that the title of the experiment in the expansion is larger than the text in the original row. Open to suggestions overall.
[ ] Show the curation status in the administrator's view. Pretty much all the information available here should be in the new browser as well.
[x] Abbreviate the Description in the row expansion (some are very long), make it look tidier. e.g. 150 words or something.

oganm commented 4 months ago

Do you think removing the bottom shadow is good for better specifying that the details belong to the row above?

No bottom shadow

Double shadow (current version)

oganm commented 4 months ago

Another particularly annoying thing is the widths of elements changing between expanded and non-expanded views causing rows to shift on click.

see the difference in position between the expanded and shrunk version. Still trying to figure out what causes the difference

ppavlidis commented 4 months ago

Shadow: seems a bit of a tossup to me but I've spent too much time looking at it so might not have the right perspective.

And yes, the shifting of the rows is something I wanted to mention as well, forgot.

oganm commented 4 months ago

Shifting rows is fixed in f488281cfbef38fa1496500c281bfbdc691225c6

oganm commented 4 months ago

Second point is #75

That issue suggests upstream fixes are needed but the missing columns from the original browser are just "Status" and "Curation".

As far as I understand "Curation" just corresponds to needsAttention component being true or false which is available to everyone.
Currently implementing status would be a bit prohibitive since existence of those analyses would require one to ask for the results

arteymix commented 3 months ago

Regarding curation status, I believe we expose it regardless of the user privileges. I will change this in the API to require at least GROUP_ADMIN.