search

PavlidisLab / GemBrow

The Gemma Browser
Apache License 2.0
3 stars 1 forks source link

High-level category counts do not respond to filters #88

Closed ppavlidis closed 7 months ago

ppavlidis commented 7 months ago

Example:

image

The value next to Disease for example, should be something like the total number of experiments selected, in response to the "Ammon's horn" filter?

arteymix commented 7 months ago

Good question.

Categories used to be selectable, so the count would reflect the number of datasets if the category would be selected. Thus the count by applying every other filter (taxa, other categories, ...).

I guess we could change that behaviour to instead reflect the number of datasets in the selection. I feel however that it would be a little useless since that information is already provided by the selection.

arteymix commented 7 months ago

Also, the counts are not visible in production and categories are not selectable. This is the correct behaviour.

arteymix commented 7 months ago

Oh, I got confused there. The disease count does not reflect the selection in organism parts. This is either a bug or an incomplete feature. Let me check.

arteymix commented 7 months ago

I looked up the code. The counts per category only reflect taxa and platform filters. Filters from other categories are simply ignored.

ppavlidis commented 7 months ago

Since this is only apparent in the debug mode, which I didn't realize, this isn't really an issue.