search

PavlidisLab / Gemma

Genomics data re-analysis
Apache License 2.0
22 stars 6 forks source link

Offset and limit getDatasetDifferentialExpressionAnalyses endpoint #841

Open oganm opened 1 year ago

oganm commented 1 year ago

I am a bit unclear on what offset and limit arguments are doing in this enpoint. It seems like unlike all other enpdoints with an offset and limit, they don't provide a totalElements component and this probably makes sense because they always return data from a single experiment as a single object which also makes these arguments entirely pointless as far as I can see.

The example here shows the lack of difference that comes from specifying a limit to one experiment with multiple resultSets and contrasts that may have been subject to the limit albeit likely not very usefully

https://gemma.msl.ubc.ca/rest/v2/datasets/12709/analyses/differential https://gemma.msl.ubc.ca/rest/v2/datasets/12709/analyses/differential?limit=1

arteymix commented 1 year ago

That's right, it's completely superfluous.

arteymix commented 1 year ago

Implementation is in https://github.com/PavlidisLab/Gemma/pull/859.

I'm getting rid of offset/limit altogether and adding a parameter for including analyses of subsets in the output.