PavlidisLab / gemma.R

An R wrapper for the Gemma RESTful API
https://pavlidislab.github.io/gemma.R/
Apache License 2.0
10 stars 1 forks source link

High level functions don't have memoisation #23

Closed oganm closed 2 years ago

oganm commented 2 years ago

As pointed out in the review here: https://github.com/Bioconductor/Contributions/issues/2533#issuecomment-1135413964 our high level functions (everything within convenience.R) don't seem to have memoisation implemented. Working on this at the high_level_memo branch but if this was intentional instead of an oversight please let me know.

oganm commented 2 years ago

This was a bit of an architectural problem which would have caused caching to fail for every function called from within another function. here i borrow the caching method from my old gemmaAPI.R where memoised functions are called directly from the main function body