search

PawanOsman / GoogleBard

GoogleBard - A reverse engineered API for Google Bard chatbot for NodeJS
https://bard.google.com
MIT License
415 stars 57 forks source link

Expose conversation object and allow it to be passed in #3

Closed Erisfiregamer1 closed 1 year ago

Erisfiregamer1 commented 1 year ago

Allows users to see the needed IDs sent to Bard, and send their own object in for usage.

Needed for projects that store Bard conversations long-term.

Erisfiregamer1 commented 1 year ago

WHOOPS. Sorry about some of that. I accidentally dropped my 1PSID cookie in there during testing (SHIT)

It's invalidated now.

Erisfiregamer1 commented 1 year ago

Thank you for the pr,

sorry but it is more look like only an adjustment for your project instead of adding a feature to the library, you removed many things and broke some features.

sorry I can't merge the pr

What did I break? The only thing I assumed broke was askStream since... well, the layout of the response and parameters changed. I'll have that fixed by tomorrow.

If you have any particular issues, make a review and show me what I need to fix.

PawanOsman commented 1 year ago

you removed some of the code to your own needs, like removing the example proxy options, and the class has 2 main functions you broke one, using string and then parsing it isn't a good way

sorry, I can't approve this pr because of the code quality and like I said this is more look like you modified the code to adjust it to your own project, +this project is Typescript if you don't use typescript you can create an issue and explain what you need to be changed and I will update it in the next versions

Erisfiregamer1 commented 1 year ago

you removed some of the code to your own needs, like removing the example proxy options, and the class has 2 main functions you broke one, using string and then parsing it isn't a good way

sorry, I can't approve this pr because of the code quality and like I said this is more look like you modified the code to adjust it to your own project, +this project is Typescript if you don't use typescript you can create an issue and explain what you need to be changed and I will update it in the next versions

The example proxy options prevented the code from running. Not a great thing to have. And you could have just told me to readd it.

Also, I just said to point out the broken functions.

PawanOsman commented 1 year ago

The example proxy options prevented the code from running. Not a great thing to have.

bro while you don't know to run an example with a proxy option and you even don't know why I added a proxy option for it then you need to create an issue instead of creating pr

sorry but I can't approve it while you already said that you don't use typescript before and now you tell me that it is Not a great thing to have. while you even don't know that this project won't work without proxy