Build system with Gulp - Githubissues

waghcwb commented 7 years ago

bower.json - Bower isn't in use for any purpose in this project, why should it be added?
.editorconfig - Was added so the code style between the dev team will be more consistent.
Template of .gitignore from here

Solve #88 and #96

waghcwb commented 7 years ago

@PawelDecowski Did I make something wrong? You didn't say nothing about this pull request

PawelDecowski commented 3 years ago

@waghcwb I couldn’t merge this for a couple reasons:

master is a stable branch pointing to the last release. Pull requests should be made to the next release branch (currently release/1.2) and agreed beforehand.
Too many changes in one branch. The pull request and branch are named “gulp integration” but the changes go way beyond that. Some of your changes were already implemented in other branches.

Having said that, your changes are extremely valuable and most of them will be implemented in v1.2.

Thank you!

PawelDecowski / jquery-creditcardvalidator