Corrupted settings file will cause application to hang indefinitely and make it unable to even start

[PawelTroka]

Basically in method Settings.Load() we do not close settings file stream before attempting to remove corrupted file. So it will hang indefinitely as we get exception in catch.

        private static Settings Load()
        {
            if (File.Exists(AppInformation.SettingsPath))
            {
                var fs = new FileStream(AppInformation.SettingsPath, FileMode.Open);
                try
                {
                    var settings = (Settings)new BinaryFormatter().Deserialize(fs);
                    settings.RestoreDirectories();
                    return settings;
                }
                catch (Exception exception)
                {
                    Logger.Error(exception, "Loading settings failed. Will remove corrupted settings file.");
                    File.Delete(AppInformation.SettingsPath);
                }
            }

            return new Settings();
        }

Resolution is quite simple actually.

        private static Settings Load()
        {
            if (!File.Exists(AppInformation.SettingsPath))
                return new Settings();
            try
            {
                using (var fs = new FileStream(AppInformation.SettingsPath, FileMode.Open))
                {
                    var settings = (Settings) new BinaryFormatter().Deserialize(fs);
                    settings.RestoreDirectories();
                    return settings;
                }
            }
            catch (Exception exception)
            {
                Logger.Error(exception, "Loading settings failed. Will remove corrupted settings file.");
                File.Delete(AppInformation.SettingsPath);
            }

            return new Settings();
        }

But that needs to be delivered fast as it may affect our users in a hard way - not being able to even run our app.

[PawelTroka]

Resolved with commit 9c5c11d.