PawseySC / pawsey-spack-config

Automated deployment system for the scientific software stack in use at Pawsey
BSD 3-Clause "New" or "Revised" License
4 stars 9 forks source link

Script: patch_shpc_pawsey_modules.sh is being called twice #239

Open AlexisEspinosaGayosso opened 10 months ago

AlexisEspinosaGayosso commented 10 months ago

Script: "patch_shpc_pawsey_modules.sh" is being called twice:

  1. From parent script: "install_shpc_containers.sh" (final line)
  2. From parent script: "post_installation_operations.sh" (final line)

We need to decide from where to call it (one or the other). Personally, I prefer to call it from the 1st parent script, as this makes a bit more clear what are the steps performed for the shpc containers. But I will leave the decision to the repo maintainers, as 2nd parent script may have been designed to perform these kinds of operations.