search

PaxInstruments / labwiz-board

A development board based on the STM32 series processors specifically targeting the STM32F103RxT series.
4 stars 2 forks source link

Button interrupt review #129

Closed charlespax closed 7 years ago

charlespax commented 7 years ago

Go through all the buttons and ensure they are on individual interrupts.

See also https://github.com/PaxInstruments/PaxInstruments-LabWiz-firmware/issues/10 and https://github.com/PaxInstruments/PaxInstruments-LabWiz-firmware/issues/12

charlespax commented 7 years ago

In commit 27a1f19b45323987bc93ce3aed916cd97b79b456

SW_PWR, GPIO_EXTI0 SW_A, GPIO_EXTI9 SW_B, GPIO_EXTI8 SW_C, GPIO_EXTI9 SW_D, GPIO_EXTI10 SW_E, GPIO_EXTI2

There is a collision between the interrupts of SW_B and SW_D. Both PC1 and PC4 are available and are suitable for replacing one of the EXTI9 lines. PC1 is on the side of the microcontroller that faces SW_A and SW_C, so that is probably a good choice. PC1 is on the top, so I think it would route nicely over to SW_A.

charlespax commented 7 years ago

Swapped WIFI_EN with SW_A to avoid interrupt sharing.