search

PaxInstruments / t400-firmware

Firmware for the Pax Instruments T400 temperature datalogger
22 stars 5 forks source link

added a #define to optionally disable all the SDCard capabilities #198

Closed davidbuzz closed 8 years ago

davidbuzz commented 8 years ago

Frees up nearly 5K of flash space. Used flash with the #define uncommented: 28656 , and with it commented out: 23620 giving a difference of: 5036

charlespax commented 8 years ago

Wow, thats awesome! I'll have to do some testing before I can merge your pull request, but I think it should be fine.

What do you think of this?Maybe we should have DISABLE_SDCARD option in t400.h. Then in sd_log.cpp we have

#ifdef DISABLE_SDCARD
  #define SDCARD 0
#else 
  #define SDCARD 1
#endif

This should give the same functionality while keeping all the config options in t400.h.

davidbuzz commented 8 years ago

that last commit moves the #define into the t400.h for you. :-) If you'd like, I can rebase it all into a single commit, or you can just merge it as-is.. your call.

charlespax commented 8 years ago

I would just merge as-is. I'll test tomorrow. Today I've been working on https://github.com/PaxInstruments/armwiz

charlespax commented 8 years ago

The only problem is when the logging start/stop button is pressed the display indicates it is logging to LD00001.CSV. I've fixed this in my next commit.