First PR on a non-work project, may have totally screwed this up =P
I noticed the README.md calls out that we should be able to delete a file using 'remove_tmp_file' but in practice, that method does not exist. Looking through the FastExcell class it appears we really need to use, 'remove_tmp_folder'
The safest, simplest approach in my mind (aside from changing the documentation) would be to create an alias. Please note, I added a test, but kept getting an error trying to run them so I'm hoping a CI/CD operation will double check this fairly simple test.
Open to any/all feedback, like I said... First time trying to work with an open source project.
Paxa
commented
11 months ago
First PR on a non-work project, may have totally screwed this up =P
I noticed the README.md calls out that we should be able to delete a file using 'remove_tmp_file' but in practice, that method does not exist. Looking through the FastExcell class it appears we really need to use, 'remove_tmp_folder'
The safest, simplest approach in my mind (aside from changing the documentation) would be to create an alias. Please note, I added a test, but kept getting an error trying to run them so I'm hoping a CI/CD operation will double check this fairly simple test.
Open to any/all feedback, like I said... First time trying to work with an open source project.