search

Paxa / fast_excel

Ultra Fast Excel Writer for Ruby
MIT License
336 stars 59 forks source link

Ruby 3.2 compatibility #90

Closed cmer closed 1 year ago

Mange commented 1 year ago

This works for me!

Although, it feels like the clean task should remain and the built library should be placed in the appropriate destination directory before the build step completes.

Here's one idea of where to look for the build library: https://github.com/rubygems/rubygems/issues/6205#issuecomment-1367870934

sly7-7 commented 1 year ago

I just hit this issue too. Maybe something like https://github.com/appsignal/appsignal-ruby/pull/907/files#diff-06aa697686fa31c50b559a6515aa8e226d3fbfe5240957912f007bbfeaf37abaR55 could work ?

Actually I don't understand, because from what I see from the issue in rubygems, it seems like the compiled library should be effectively be taken from the lib directory, which is the case here. https://github.com/Paxa/fast_excel/blob/master/lib/fast_excel/binding.rb#L16 (unless I'm missing something, which very possible). Would that mean that removing the clean task here is the right move ?

BrianHawley commented 1 year ago

This can be closed now, as #91 and #92 solved the issue.